Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add patch for Chrome run time issue - #17490

Closed
zoracon wants to merge 2 commits into
EFForg:masterfrom
zoracon:chrome-bug-patch
Closed

zoracon wants to merge 2 commits into
EFForg:masterfrom
zoracon:chrome-bug-patch

Conversation

@zoracon

@zoracon zoracon commented Feb 21, 2019 •

Copy link
Copy Markdown
Contributor

Caught that at times "item" is not defined during "show counter" test. Causing Chrome and Chrome Beta test to fail. Adding this in as a stop gap so this test can continue for future PRs.

Related: #17274

@zoracon
zoracon requested a review from Hainish February 21, 2019 01:06
@zoracon
zoracon removed the request for review from Hainish February 22, 2019 00:36
@zoracon

zoracon commented Feb 22, 2019

Copy link
Copy Markdown
Contributor Author

Looks like I now botched the Firefox flow with this change, gonna look into the test itself more to see how to improve on it

@zoracon zoracon closed this Feb 22, 2019
@zoracon zoracon reopened this Feb 22, 2019
@pipboy96 pipboy96 added the bug label Sep 17, 2019
Comment thread chromium/pages/options/ux.js Resolved
@zoracon

zoracon commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

This has been resolved through amending the selenium test, closing this out

@zoracon zoracon closed this Oct 9, 2019
@zoracon
zoracon deleted the chrome-bug-patch branch May 15, 2020 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants